Code Inspection: Member can be made static(shared) (non-private accessibility)
Consider the method
If the solution-wide inspection is enabled, ReSharper suggests that
Here’s what the MSDN documentation has to say about it:
- Members that do not access instance data or call instance methods can be marked as static (Shared in Visual Basic). After you mark the methods as static, the compiler will emit non-virtual call sites to these members. Emitting nonvirtual call sites will prevent a check at runtime for each call that makes sure that the current object pointer is non-null. This can achieve a measurable performance gain for performance-sensitive code. In some cases, the failure to access the current object instance represents a correctness issue.
For the solution-wide inspection to work, you need either or both of the following:
The simplified global usage checking is enabled — Show unused non-private type members when solution-wide analysis is off on the page of ReSharper options.
The solution-wide analysis is enabled — Enable solution-wide analysis on the page of ReSharper options.
Note that even if a symbol has no direct usages in your solution and ReSharper warns you about it, there could be cases where symbols are used indirectly — e.g. via reflection — or they could just be designed as public API. In all those cases you would want to suppress the usage-checking inspection for the symbol in question, and there are several ways to do so:
The recommended way is to decorate the implicitly used symbols with code annotation attributes. There are two attributes for this purpose: [UsedImplicitly] and [PublicAPI], which are functionally similar, but let you and your teammates understand how the symbol is actually used.
You can also suppress usage-checking inspections with any custom attribute. To do so, mark the definition of that attribute with the [MeansImplicitUse] attribute.
And finally, you can suppress a specific usage-checking inspection as any other code inspection with a suppression comment or a suppression attribute.