ReSharper 2018.2 Help

Code Inspection: Member can be made static(shared) (non-private accessibility)

Consider the method Print below:

public class Foo { public void Test() { Print("John"); } public void Print(string name) { Console.WriteLine("Hello, {0}!", name); } }
Public Class Foo Public Sub Test() Print("John") End Sub Public Sub Print(name As String) Console.WriteLine("Hello, {0}!", name) End Sub End Class

If the solution-wide inspection is enabled, ReSharper suggests that Print has no instance usages and can be made static. But what’s the point? Well, as it turns out, static members yield a small performance benefit under particular circumstances.

Here’s what the MSDN documentation has to say about it:

- Members that do not access instance data or call instance methods can be marked as static (Shared in Visual Basic). After you mark the methods as static, the compiler will emit non-virtual call sites to these members. Emitting nonvirtual call sites will prevent a check at runtime for each call that makes sure that the current object pointer is non-null. This can achieve a measurable performance gain for performance-sensitive code. In some cases, the failure to access the current object instance represents a correctness issue.

For the solution-wide inspection to work, you need either or both of the following:

  • The simplified global usage checking is enabled — Show unused non-private type members when solution-wide analysis is off on the Code Inspection | Settings page of ReSharper options.

  • The solution-wide analysis is enabled — Enable solution-wide analysis on the Code Inspection | Settings page of ReSharper options.

Note that even if a symbol has no direct usages in your solution and ReSharper warns you about it, there could be cases where symbols are used indirectly — e.g. via reflection — or they could just be designed as public API. In all those cases you would want to suppress the usage-checking inspection for the symbol in question, and there are several ways to do so:

Last modified: 17 October 2018

See Also