Make Method Non-Static refactoring
This refactoring allows you to convert a static method into an instance method of the original or another type. The target type for the new instance method can be selected from one of the types passed as parameters to the method. All usages, implementations and overrides of the method are automatically updated.
This refactoring can only be applied to static methods that have at least one parameter of a type defined in the current solution.
In the example below, we use this refactoring to convert a static method Merge of the MetaInfo class into an instance method of the same type:
| Before refactoring | After refactoring |
|---|---|
class MetaInfo
{
public string Id { get; set; }
public string Name { get; set; }
public static MetaInfo Merge(MetaInfo m1,
MetaInfo m2)
{
return new MetaInfo
{
Id = m1.Id + m2.Id,
Name = m1.Name + m2.Name
};
}
}
class Test
{
public Test()
{
var info1 =
new MetaInfo(){Id = "123", Name = "AA"};
var info2 =
new MetaInfo(){Id = "456", Name = "BB"};
var merged =
MetaInfo.Merge(info1, info2);
}
} | class MetaInfo
{
public string Id { get; set; }
public string Name { get; set; }
public MetaInfo Merge(MetaInfo m2)
{
return new MetaInfo
{
Id = Id + m2.Id,
Name = Name + m2.Name
};
}
}
class Test
{
public Test()
{
var info1 =
new MetaInfo(){Id = "123", Name = "AA"};
var info2 =
new MetaInfo(){Id = "456", Name = "BB"};
var merged =
info1.Merge(info2);
}
} |
In the following example, the static method Merge that works with MetaInfo objects is defined in the class Service. We use the refactoring to make Merge an instance method of the class MetaInfo, where it logically belongs:
| Before refactoring | After refactoring |
|---|---|
class Service
{
public static MetaInfo Merge(MetaInfo m1,
MetaInfo m2)
{
return new MetaInfo
{
Id = m1.Id + m2.Id,
Name = m1.Name + m2.Name
};
}
}
class MetaInfo
{
public string Id { get; set; }
public string Name { get; set; }
}
class Test
{
public Test()
{
var info1 =
new MetaInfo(){Id = "123", Name = "AA"};
var info2 =
new MetaInfo(){Id = "456", Name = "BB"};
var merged =
Service.Merge(info1, info2);
}
} | class Service
{
}
class MetaInfo
{
public string Id { get; set; }
public string Name { get; set; }
public MetaInfo Merge(MetaInfo m2)
{
return new MetaInfo
{
Id = Id + m2.Id,
Name = Name + m2.Name
};
}
}
class Test
{
public Test()
{
var info1 =
new MetaInfo(){Id = "123", Name = "AA"};
var info2 =
new MetaInfo(){Id = "456", Name = "BB"};
var merged =
info1.Merge(info2);
}
} |
To convert a static method into an instance method
- Place the caret at the declaration or a usage of a static method in the editor, or select it in the Structure window.
- Do one of the following:
- Press Ctrl+Shift+R and then choose Make Method Non-Static
- Choose in the main menu.
- Select a parameter from the list. The method will be converted to the instance method of the parameter type.
- To apply the refactoring, click Next.
- If no conflicts are found, JetBrains Rider performs the refactoring immediately. Otherwise, it prompts you to resolve conflicts.
