Upsource 3.5 Help

Monitoring changes introduced by teammates

As a watcher you typically perform the following sequence of tasks:

  • Go to the review and locate the changes.
  • Read comments and optionally participate in discussion.

Locate changes

When someone invites you to take part in a review, you'll receive a notice in your e-mail containing a direct link to that review. You'll be also updated of any consequent changes within this review.

Follow the link to proceed to the review page.

Its main pane shows the review timeline that lists all events and comments related to the review:

assets/codereview/CR_main_pane_watcher_large.png

The files with changes are listed under the Overview tab. Click on the file name to display the inline diff:

CR_click_file_for_diff.png

From here you can go to a side-by-side diff or view the entire file by pushing the corresponding button.

assets/codereview/CR_inline_diff_watcher_large.png

To return to the timeline view, click Timeline or press Esc:

CR_click_timeline.png

Read and post comments

You can post comments, addressing them to the author and other participants, and reply to the comments left by others.

There are three types of comments:

  • Review comment is not tied up to any particular file or part of code - its subject matter may be anything within the scope of the review.
  • Code selection comment is intended to pinpoint a particular code fragment in one of the files being reviewed.
  • Line comment is associated with a specific line of code.

To post a review comment

  • Type your message in the text field at the bottom and click Add Comment:

    assets/codereview/CR_genComment_large.png

To post a line comment

  1. Click on the desired file to display its inline diff.
  2. Select the line you want to comment on by clicking the edit icon to the left:
    Add line comment
  3. Enter your message in the text box and click Add comment:
    Add line comment

To post a code selection comment:

  1. Select the desired file and go Side-by-side diff or View file.
  2. Select the lines you want to discuss and choose Comment on selection from the pop-up menu.
  3. Type in your message and click Add Comment:
    assets/codereview/CR_comMenu_large.png

Posted code selection comments and line comments are embedded in code and highlighted with yellow.

assets/codereview/CR_inlineComment_large.png

When a discussion thread comes to a logical end, it can be marked as resolved.

Unsubscribe from e-mail updates

To discontinue monitoring a review and stop getting updates in your e-mail, navigate to the review main page and remove yourself from the watchers list - in the right pane, click on your user pic and confirm the deletion:

Remove watcher
Last modified: 1 December 2016