'FailNow' in a non-test goroutine

Reports calls to testing.T.FailNow and similar methods located in goroutines in test files.

Methods like FailNow call runtime.Goexit and stop the calling goroutine, not the test. Therefore, they must only be called from the goroutine that runs the test or benchmark.

For more information about FailNow, see func (*T) FailNow at go.dev.

Example:

func TestFoo(t *testing.T) {
  go func() {
    t.Fatal("oops") //exits goroutine, not TestFoo
  }()
}

After the Replace with 'Error' and 'return' quick-fix is applied:

func TestFoo(t *testing.T) {
  go func() {
    t.Error("oops")
    return
  }()
}

Inspection Details
Available in:	GoLand 2023.3
Plugin:	Go, 233.SNAPSHOT

Last modified: 13 July 2023