Use of Optional.ofNullable with null or not-null argument
Reports uses of Optional.ofNullable()
where always null or always not-null argument is passed. There's no point in using Optional.ofNullable()
in this case: either Optional.empty()
or Optional.of()
should be used to explicitly state the intent of creating an always-empty or always non-empty optional respectively. It's also possible that there's a mistake in Optional.ofNullable()
argument, so it should be examined.
Example:
Optional<String> empty = Optional.ofNullable(null); // should be Optional.empty();
Optional<String> present = Optional.ofNullable("value"); // should be Optional.of("value");
Inspection Details | |
---|---|
Available in: | IntelliJ IDEA 2023.3, Qodana for JVM 2023.3 |
Plugin: | Java, 233.SNAPSHOT |
Last modified: 13 July 2023